Add an spi::config::BitOrder enum#222
Merged
Merged
Conversation
Vollbrecht
approved these changes
Mar 27, 2023
Vollbrecht
left a comment
Vollbrecht
left a comment
Collaborator
There was a problem hiding this comment.
I tested it on an esp32c3 and seems to work as accepted.
MSB First:
LSB First:
| pub bit_order: BitOrder, | ||
| pub cs_active_high: bool, | ||
| pub input_delay_ns: i32, | ||
| } |
Collaborator
There was a problem hiding this comment.
NIT: for consistency maybe add an pub fn bitorder to the Config builder pattern.
Contributor
Author
There was a problem hiding this comment.
Thanks, I missed that 😄 Added it now
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new enum spi::config::BitOrder which can be used to specify the order of the bits transfered/received. I tried to test all the variants of the enum, but I am new to embedded development, so I would appreciate if someone else would also test them :)
Thanks @Vollbrecht and @Dominaezzz for the help in the Matrix channel!