Async & blocking adaptors for the Wifi driver (supersedes #240) #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 26, 2023
Vollbrecht
reviewed
Apr 3, 2023
Vollbrecht
reviewed
Apr 3, 2023
MabezDev
reviewed
May 4, 2023
The stubs just block on the sync variants of the functions, and return a 'ready' future. In a later iteration, the async functions that block can be replaced with proper futures. Also added an example of using the async Wifi. Feedback and comments welcome!
…nts. The implementation of asynch::Wifi is still dependent on "experimental" feature, because embedded-svc only exports the trait with "experimental". `get_configuration`, `set_configuration`, `get_capabilities`, `is_started`, and `is_connected` methds are not async in AsyncWifiDriver, because I don't think it make sense since they return immediately on the ESP32 platform. However, they still have async wrappers in the `asynch::Wifi` implementation to fulfill that trait.
ivmarkov
force-pushed
the
wifi_async
branch
4 times, most recently
from
2c830a9 to
e4483c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To build, use, e.g.:
cargo build --example wifi_async --target xtensa-esp32-espidf --features experimental,nightly