Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc improvements #102

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Misc improvements #102

merged 2 commits into from
Dec 16, 2022

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Dec 16, 2022

  • introduce phy_enable_usb feature
  • Update README
  • initialize takes the Rng driver instead of the raw PAC peripheral

Closes #101

MabezDev
MabezDev approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MabezDev MabezDev merged commit 09e3ab9 into main Dec 16, 2022
@bjoernQ bjoernQ deleted the misc-improvements branch February 1, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't use phy_bbpll_en_usb unless USB_SERIAL_JTAG is really used (ESP32-C3, ESP32-S3)
2 participants
@bjoernQ @MabezDev