ESP32-C2 BLE #110
Merged
ESP32-C2 BLE #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
approved these changes
Jan 24, 2023
|
I never did manage to get this working, just FYI @bjoernQ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for ESP32-C2 BLE
I observed that sometimes it doesn't get the
Disconnectevent - not sure why or what we can do about that. I will try to add some timeout and automatic disconnect to the toy BLE stack used and see if that helpsThere are a lot
todo!()s here - that's because apparently the controller doesn't use much of the NPL functions - we could just set them to NULL but then if they get used in future it will be very inconvenient to find what is exactly missing.This also contains some refactoring to the previous BLE implementation to better separate the chip specific things from the common code.