Smoltcp 0.9 upgrade

[MabezDev]

Was a bigger job than I first anticipated 😅.

• Adapt to new smoltcp::Device changes
• Merges Network and Wifi to create WifiStack
• Update examples
• Use heapless instead of hand rolled queue
• fmt the entire project

Closes #123

[bjoernQ]

Thanks a lot - this looks very good! Also, good you replaced that Queue implementation since we depend on Heapless already

Code looks fine but I have no idea why the re-format changed so much - I thought I always do a format 🤷‍♂️

When testing I found a few things (which I cannot mark in the diff)

• The ESP32 BLE example crashed for me because BT_INTERNAL_QUEUE was full when trying to enqueue data - increasing it to 10 in btdm.rs made it work

A couple of "unused Result" lints because of the new queue

warning: unused `Result` that must be used
   --> esp-wifi\src\esp_now\mod.rs:490:9
    |
490 | /         queue.enqueue(ReceivedData {
491 | |             len: slice.len() as u8,
492 | |             data: data,
493 | |             info,
494 | |         });
    | |__________^
    |
    = note: this `Result` may be an `Err` variant, which should be handled
    = note: `#[warn(unused_must_use)]` on by default

warning: unused `Result` that must be used
    --> esp-wifi\src\ble\npl.rs:1229:9
     |
1229 | /         queue.enqueue(ReceivedPacket {
1230 | |             len: (len + 3) as u8,
1231 | |             data,
1232 | |         });
     | |__________^
     |
     = note: this `Result` may be an `Err` variant, which should be handled

warning: unused `Result` that must be used
    --> esp-wifi\src\ble\npl.rs:1250:9
     |
1250 | /         queue.enqueue(ReceivedPacket {
1251 | |             len: (len + 1) as u8,
1252 | |             data,
1253 | |         });
     | |__________^
     |

But a real problem is, the static_ip example doesn't work anymore. Seems like https://github.com/esp-rs/esp-wifi/blob/5c66d0e15577c1f5d7b909701e2874ea71d02eb2/esp-wifi/src/wifi_interface.rs#L448-L464 got lost

[MabezDev]

The ESP32 BLE example crashed for me because BT_INTERNAL_QUEUE was full when trying to enqueue data - increasing it to 10 in btdm.rs made it work

I imagine this was silently failing, as the bool from enqueue was not checked, so I guess its good we now check it :D.

But a real problem is, the static_ip example doesn't work anymore. Seems like

Thanks! This got lost in the refactor. I forgot to mention in the top level PR, but work() on the sockets now just defer to the stack work function, reducing the amount of code doing the same thing, but I guess I borked it a little bit :D. Should be fixed now.

[MabezDev]

Code looks fine but I have no idea why the re-format changed so much - I thought I always do a format man_shrugging

This might be because I format with nightly, maybe there are changes in the way it formats in newer versions? 🤔

[bjoernQ]

The ESP32 BLE example crashed for me because BT_INTERNAL_QUEUE was full when trying to enqueue data - increasing it to 10 in btdm.rs made it work

I imagine this was silently failing, as the bool from enqueue was not checked, so I guess its good we now check it :D.

Yes, I think it was like that - I think that old Queue was one of my earliest creations in Rust and got copied from project to project for way too long 🤣

[bjoernQ]

Now the static_ip example crashes with

!! A panic occured in 'esp-wifi\src\wifi_interface.rs', at line 171, column 29

PanicInfo {
    payload: Any { .. },
    message: Some(
        index out of bounds: the len is 0 but the index is 0,
    ),
    location: Location {
        file: "esp-wifi\\src\\wifi_interface.rs",
        line: 171,
        col: 29,
    },
    can_unwind: true,
}

I think we lost this (storage for ip_addr and also multicast_storage) https://github.com/esp-rs/esp-wifi/blob/5c66d0e15577c1f5d7b909701e2874ea71d02eb2/esp-wifi/src/wifi/utils.rs#L21-L23

Probably multicasts also won't work because of this anymore but we don't have an example for it, currently

I haven't seen how this is done in 0.9.x now 🤷‍♂️

[MabezDev]

Okay, now it should work - I actually tested it properly now :D. In smoltcp 0.9 there are defaults: https://github.com/smoltcp-rs/smoltcp/blob/9027825c16c9c3fbadb7663e56d64b590fc95d5a/src/lib.rs#L141 so multicast should still work.

[bjoernQ]

Thanks for taking care of this