Skip to content

Add basic AP support #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Add basic AP support #134

merged 2 commits into from
Feb 20, 2023

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Feb 17, 2023

This adds support for creating an open access-point
Closes #60

This will enable us to implement WiFi provisioning via an open AP. Doing that in a convenient way will need a few more things which don't belong here - I plan to create a demo / example for that outside of this repository.

  • trying to create a non-open AP currently triggers an exception in the WiFi driver
    • in hostapd_setup_wpa_psk
    • calling ROM function multi_heap_malloc_impl
  • not sure if is_connected should do anything useful in AP mode - currently it doesn't
  • there are quite a lot of places now where we need to differentiate between the modes
    • not sure how we can make that nicer, I also would prefer to improve that in a separate PR to keep this initial PR small

If we want to support APSTA (AP and STA at the same time) we need a larger refactoring - plus APSTA currently triggers an exception in the wifi driver. Investigating this might be a lot of effort and something for another day.

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Both examples work well for me. Just a couple if comments to address.

@bjoernQ bjoernQ merged commit 4b7ec1c into main Feb 20, 2023
@bjoernQ bjoernQ deleted the feature/ap-support branch February 20, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider support for Soft AP mode
2 participants