Rework initialization #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esp-wifi/src/lib.rs
Outdated
Comment on lines
119
to
123
| #[cfg(any(feature = "esp32c3", feature = "esp32c2", feature = "esp32c6"))] | ||
| /// Initialize for using WiFi / BLE | ||
| /// This will initialize internals and also initialize WiFi and BLE | ||
| pub fn initialize( | ||
| systimer: Alarm<Target, 0>, | ||
| rng: hal::Rng, | ||
| radio_clocks: hal::system::RadioClockControl, | ||
| clocks: &Clocks, | ||
| ) -> Result<(), InitializationError> { | ||
| init_heap(); | ||
| type Timer = Alarm<Target, 0>; | ||
|
|
||
| #[cfg(feature = "esp32c6")] | ||
| if clocks.cpu_clock != MegahertzU32::MHz(160) { | ||
| return Err(InitializationError::WrongClockConfig); | ||
| } | ||
| #[cfg(any(feature = "esp32", feature = "esp32s3", feature = "esp32s2"))] | ||
| type Timer = hal::timer::Timer<hal::timer::Timer0<hal::peripherals::TIMG1>>; |
There was a problem hiding this comment.
Should we give those types a public visibility, so that if someone were to wrap initialize() inside another function, they wouldn't have to redefine those types again.
There was a problem hiding this comment.
You mean just for convenience? 🤔 Sure that shouldn't be a problem. Not sure if the naming is a bit too generic then - probably better to rename this if we make it public
MabezDev
requested changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #193
initializefunction for RV and Xtensaasyncfeature selection