Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global allocator #73

Merged
merged 4 commits into from
Oct 11, 2022
Merged

Remove global allocator #73

merged 4 commits into from
Oct 11, 2022

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Oct 7, 2022

Previously esp-wifi contained its own global allocator (for no real reason) which prevented users from using their own allocator or none at all.

Instead of the allocator it now uses linked-list-allocator directly with an array placed in .bss

This PR also contains these smaller changes

  • improved BLE implementation (by not doing just nothing on interrupt-enable/disable)
  • on ESP32 the Bluetooth RAM feature is only activated when the BLE feature is activated

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice to keep the esp-wifi stuff contained in esp-wifi :)

src/lib.rs Outdated Show resolved Hide resolved
Co-authored-by: Ryan Butler <thebutlah@gmail.com>
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test this exhaustively, but the code looks fine and the examples I did test were still working as expected so LGTM.

@bjoernQ bjoernQ merged commit ebc21bb into main Oct 11, 2022
@bjoernQ bjoernQ deleted the remove-global-allocator branch December 16, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants