Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-introduce a Queue for TX #96

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Re-introduce a Queue for TX #96

merged 1 commit into from
Dec 2, 2022

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Dec 1, 2022

I already did that in #52 and back then it caused major pain and was reverted - I just did it again and it seems to work for me (but it seemed like that already last time)

Closes #54

MabezDev
MabezDev approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on s3 & c3 and both seemed to work on the DHCP example. LGTM.

@bjoernQ bjoernQ merged commit 9034a26 into main Dec 2, 2022
@bjoernQ bjoernQ deleted the reintroduce-tx-queue branch December 2, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

@jessebraham jessebraham Awaiting requested review from jessebraham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use a queue for TX packets
2 participants
@bjoernQ @MabezDev