Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve packet dumps #165

Merged
merged 2 commits into from Apr 19, 2023
Merged

Improve packet dumps #165

merged 2 commits into from Apr 19, 2023

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Apr 19, 2023

  • packet-dump feature also dumps HCI packets
  • packet-dump just dumps the raw data
  • have an extcap in extras/esp-wifishark

@bjoernQ bjoernQ requested a review from JurajSadel April 19, 2023 09:55
JurajSadel
JurajSadel approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjoernQ bjoernQ merged commit 7dc4595 into main Apr 19, 2023
12 checks passed
@bjoernQ bjoernQ deleted the improve-packet-dumps branch April 19, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JurajSadel JurajSadel JurajSadel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bjoernQ @JurajSadel