-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: flash with wsl2 #179
Conversation
This looks to work for me in WSL 2. Steps to test:
Assuming your board shows up without an error, you're good to flash |
Definitely works, thank you so much!
I thought VID and PID were necessary for the crate to work, but this simplifies everything. |
It is required for flashing via USB-SERIAL-JTAG, as it has a different reset routine, but other USB serial chips should just work :). In the future, we might want to add a CLI flag to choose which reset routine to use. |
@JurajSadel this looks good, thank you for pursuing this issue! Would you mind also adding notes to both |
I like the commit as it is, it works and this is all I needed, but you might want to add some tiny warning like "The type of the tty port is unknown". I think it would really help reasoning about some future issues, especially with USB-SERIAL-JTAG. Left as it is you'll never know if you have real vid and pid detected or they are silent fake zeros. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes!
Closes #166
Note: It is not possible to flash
usb-serial-jtag
chips withWSL2
because the reset also resetsserial-jtag-peripheral
which disconnects the chip from WSL2.