Detect the bootloader and partition table from ESP-IDF when able #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
approved these changes
May 30, 2022
Member
MabezDev
left a comment
MabezDev
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for looking into this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #185
When the
esp-idf-syspackage is built, we store the paths to the already-compiledbootloader.binandpartition-table.binfiles. If no alternatives have been specified via either command-line arguments and/or Cargo package metadata, then these binaries will be used instead of the defaults included withespflash.When users are not building
esp-idf-sys, (ie. bare-metal) then the behaviour does not change.@MabezDev @bjoernQ @ivmarkov @N3xed will this cause any issues which I have not thought of?