Add support for erasing otadata#229
Merged
Merged
Conversation
jessebraham
reviewed
Sep 9, 2022
jessebraham
approved these changes
Sep 13, 2022
Member
There was a problem hiding this comment.
Awesome, thanks for getting that fixed up. LGTM!
One other small thing, we're in the process of re-licensing the project so if you wouldn't mind please commenting in this RFC stating that this is okay with you that'd be much appreciated!
Contributor
Author
Looking at the last comment I guess it's already decided, but I'm definitely in favor of this change. |
svenstaro
reviewed
Sep 19, 2022
svenstaro
reviewed
Sep 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #119
This PR adds a
--erase-otadataargument when flashing.This will force using stub since it's using the
ERASE_REGIONcommand.I also implemented the
ERASE_FLASHcommand but didn't do any particular test nor did I implement an argument switch to use it.I guess implementing two other commands for both
ERASE_REGIONandERASE_FLASHwould make sense, but having a first support for erasing the otadata partition thus allowing to reflash the chip after an OTA update seems more of a priority.