connection: Swap error and status in CommandResponse #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jessebraham merged 1 commit into esp-rs:main from yaak-ai:bugfix/CommandResponse_swap-error-status

Oct 24, 2022

Contributor

maximeborges commented Oct 24, 2022

In stub_flasher.c:319 we can see that error is sent before status:

SLIP_send_frame_data(error);
SLIP_send_frame_data(status);
SLIP_send_frame_delimiter();

This PR swap those two fields in the CommandResponse struct.


          connection: Swap error and status in CommandResponse

eebaaae

jessebraham approved these changes

View reviewed changes

Member

jessebraham left a comment

Sneaky, good catch!

jessebraham merged commit c2a4854 into esp-rs:main

maximeborges deleted the bugfix/CommandResponse_swap-error-status branch

October 24, 2022 16:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet