Skip to content

connection: Swap error and status in CommandResponse - #269

Merged
jessebraham merged 1 commit into
esp-rs:mainfrom
yaak-ai:bugfix/CommandResponse_swap-error-status
Oct 24, 2022
Merged

connection: Swap error and status in CommandResponse#269
jessebraham merged 1 commit into
esp-rs:mainfrom
yaak-ai:bugfix/CommandResponse_swap-error-status

Conversation

@maximeborges

@maximeborges maximeborges commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

In stub_flasher.c:319 we can see that error is sent before status:

SLIP_send_frame_data(error);
SLIP_send_frame_data(status);
SLIP_send_frame_delimiter();

This PR swap those two fields in the CommandResponse struct.

jessebraham
jessebraham approved these changes Oct 24, 2022
View reviewed changes

@jessebraham jessebraham left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sneaky, good catch!

@jessebraham
jessebraham merged commit c2a4854 into esp-rs:main Oct 24, 2022
@maximeborges
maximeborges deleted the bugfix/CommandResponse_swap-error-status branch October 24, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jessebraham jessebraham jessebraham approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maximeborges @jessebraham