Replace --erase-otadata with --erase-parts and --erase-data-parts - #273
Merged
Conversation
Contributor
Author
|
@jessebraham Can you do a release of |
Member
|
I've published |
maximeborges
marked this pull request as ready for review
October 26, 2022 08:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having a
--erase-otadataflag to erase only the otadata partition, we can now erase any partitions by their labels with--erase-parts part1,part2or any data partition by their sub-types using--erase-data-parts ota,nvsand so on.This PR is awaiting on esp-rs/esp-idf-part#5