Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace --erase-otadata with --erase-parts and --erase-data-parts #273

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

maximeborges
Copy link
Contributor

Instead of having a --erase-otadata flag to erase only the otadata partition, we can now erase any partitions by their labels with --erase-parts part1,part2 or any data partition by their sub-types using --erase-data-parts ota,nvs and so on.

This PR is awaiting on esp-rs/esp-idf-part#5

@maximeborges
Copy link
Contributor Author

@jessebraham Can you do a release of esp-idf-part so I can update the dependency here to use esp-rs/esp-idf-part#5?

@jessebraham
Copy link
Member

I've published esp-idf-part@0.1.1.

@maximeborges maximeborges marked this pull request as ready for review October 26, 2022 08:56
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@jessebraham jessebraham merged commit abd8208 into esp-rs:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants