Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up unused code, optimize comparison in find_serial_port #302

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Clean up unused code, optimize comparison in find_serial_port #302

merged 2 commits into from
Nov 22, 2022

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Nov 18, 2022 •
edited
Loading

This is just a small housekeeping PR to keep my fork free of warnings, as well as some cleanup/optimization I've noticed.

@bugadani bugadani changed the title Clean up unused code Clean up unused code, optimize comparison in find_serial_port Nov 18, 2022
jessebraham
jessebraham approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I didn't know about the eq_ignore_ascii_case function, handy!

@jessebraham jessebraham merged commit d555956 into esp-rs:main Nov 22, 2022
@bugadani bugadani deleted the cleanup branch November 22, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bugadani @jessebraham