Skip to content

Make Interface constructor public#354

Merged
jessebraham merged 1 commit into
esp-rs:mainfrom
linearlabs:interface
Feb 15, 2023
Merged

Make Interface constructor public#354
jessebraham merged 1 commit into
esp-rs:mainfrom
linearlabs:interface

Conversation

@bugadani

Copy link
Copy Markdown
Contributor

As it turns out, users (me) might actually want to construct Interface objects. While the fields are public, the raspberry-enabled new does a few useful things that I don't necessarily want to duplicate in my program.

@jessebraham jessebraham left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable enough, I think it was only protected because the interface module at one point was private, so this probably just never got updated. Thanks!

@jessebraham jessebraham merged commit 4665742 into esp-rs:main Feb 15, 2023
@bugadani bugadani deleted the interface branch February 15, 2023 15:43
@bugadani

Copy link
Copy Markdown
Contributor Author

I missed it, too, when I was poking at raspberry support :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants