Fix Windows installation#399
Merged
Merged
Conversation
jessebraham
approved these changes
May 26, 2023
Member
jessebraham
left a comment
jessebraham
left a comment
There was a problem hiding this comment.
Thanks for taking care of this, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolver = "2"to the workspaceCargo.tomlcargodependency uses the featurevendored-opensslonly on Unix systemscargoversion1.65Those changes seem to make the installation succeed in all OSs (and does not require installing
perlon Windows). I tested the installation in:Any other test is appreciated:
cargo install cargo-espflash --git https://github.com/SergioGasquez/espflash --branch fix/windows-install