Do not require the --partition-table argument when erasing partitions#413
Merged
Conversation
SergioGasquez
approved these changes
May 30, 2023
SergioGasquez
left a comment
SergioGasquez
left a comment
Member
There was a problem hiding this comment.
Changes LGTM, tested it a bit, and it behaves as expected, thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than perform error handling within
clapfor this, we just move the check (which already existed) intoespflashinstead, after any package metadata has been read. This will still return an error if no partition table was able to be found, however it should be able to pick up partition tables provided via cargo metadata just fine.Closes #390