Skip to content

Update the release workflow #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2023
Merged

Update the release workflow #421

merged 1 commit into from
Jun 5, 2023

Conversation

jessebraham
Copy link
Member

@jessebraham jessebraham requested a review from SergioGasquez June 2, 2023 17:56
SergioGasquez
SergioGasquez approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think it is way more elegant now. Maybe we could merge the two packages actions by adding a bunch of ifs, but not sure if it's worth.

@jessebraham jessebraham merged commit 65bd430 into esp-rs:main Jun 5, 2023
@jessebraham jessebraham deleted the fixes/ci branch June 5, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessebraham @MabezDev @SergioGasquez