Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

softAP Subnet Mask unable to be set for DHCP #2578

Closed
mtongnz opened this issue Oct 5, 2016 · 2 comments
Closed

softAP Subnet Mask unable to be set for DHCP #2578

mtongnz opened this issue Oct 5, 2016 · 2 comments
Labels
waiting for feedback Waiting on additional info. If it's not received, the issue may be closed.

Comments

@mtongnz
Copy link
Contributor

mtongnz commented Oct 5, 2016

When running in softAP mode, there is no way to set what subnet mask is sent to DHCP clients. WiFi.softAPConfig allows you to set the subnet for the ESP8266 but this isn't passed to the DHCP server - it always assigns 255.255.255.0

It appears to me that this is set in Arduino/tools/sdk/lwip/src/app/dhcpserver.c on lines 135-150. The subnet mask is hard coded in.

Is it possible to link WiFi.softAPConfig to set these values or provide another function to achieve this?

There seem to be a few other issues logged which incorrectly state the subnet isn't set at all. The subnet appears to be set correctly on the ESP8266, just not given out by the DHCP server.

Thanks

@devyte
Copy link
Collaborator

devyte commented Oct 11, 2017

@mtongnz how does PR #3637 work for you?

@devyte devyte added the waiting for feedback Waiting on additional info. If it's not received, the issue may be closed. label Oct 11, 2017
@mtongnz
Copy link
Contributor Author

mtongnz commented Oct 12, 2017

This issue was resolved with #2648. Sorry I forgot to close this :)

@mtongnz mtongnz closed this as completed Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for feedback Waiting on additional info. If it's not received, the issue may be closed.
Projects
None yet
Development

No branches or pull requests

2 participants