add missing constants to variants/oak #4222
Merged
Conversation
|
For anyone using PlatformIO, you can workaround this until released by adding the following to your build_flags = -DNUM_ANALOG_INPUTS=1 -DNUM_DIGITAL_PINS=11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
headers from the Oak didn't import
common.h, among other problems. for example, Firmata fails to build ifNUM_ANALOG_INPUTSis not defined.I also modified the SCL/SCA definitions to look like the other variants.