Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update upload.py #6781
earlephilhower left a comment
Looks like a good way to make things work w/o requiring people to update the plugins. A little concerned about the duplication of the if-condition. Maybe we can safely eat
Only eating the '--end' is not working because ['write_flash', '0x0'] is appended and the binary is moved to the end. Also if another unknown plugin should use upload.py with two '--end' in one command esptool would not execute twice or (n-) times. As I'm a python beginner I did not know nesting if..else statements is a bad thing. What could happen while using the outer if-else (other than an ugly diff)?