Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify phonemes OY, Y:, y, @ and r, and add more fixes to word rules #595

Closed
wants to merge 38 commits into from

Conversation

@hozosch
Copy link
Contributor

hozosch commented Mar 18, 2019

No description provided.

@hozosch hozosch changed the title modify phonemes OY and Y: and add more fixes to word rules modify phonemes OY, Y: and r, and add more fixes to word rules Mar 19, 2019
@hozosch hozosch changed the title modify phonemes OY, Y: and r, and add more fixes to word rules modify phonemes OY, Y: @ and r, and add more fixes to word rules Mar 19, 2019
hozosch added 21 commits Mar 20, 2019
I had to fix these other errors to make this one show up
…on and phonemes tests, except the new changes for DE
I'm sorry for creating all these commits, I just want the travis CI builds to succede. I wasn't aware the standard odo repository is different from the current espeak ng.
… account when reverting back
@hozosch

This comment has been minimized.

Copy link
Contributor Author

hozosch commented Mar 22, 2019

I know, I made it all more complicated than it needed to be. At least, I know that the odo repository is different to the one I want to merge this pull request with, and now, I know how to read the log from the travis site, so I'm going to trust that now instead of odo, and just use odo to synchronize with the original Espeak project, so that changes I didn't make are included to avoid any conflicts.

@hozosch hozosch closed this Mar 22, 2019
@hozosch hozosch reopened this Mar 22, 2019
hozosch added 3 commits Mar 22, 2019
I'm sorry for that. I temporarily copied the test files to my desktop and moved this shortcut into the repository folder as well as my changed test files.
What a wally I have been! Again, same reason as QWS.lnk
@hozosch hozosch changed the title modify phonemes OY, Y: @ and r, and add more fixes to word rules modify phonemes OY, Y:, y, @ and r, and add more fixes to word rules Mar 23, 2019
valdisvi added a commit that referenced this pull request Apr 4, 2019
@valdisvi

This comment has been minimized.

Copy link
Member

valdisvi commented Apr 4, 2019

@hozosch I merged your changes as a new single commit.
Note, that I ignored some unnecessary changes like this commit, where, for some reason, you replaced escaped linebreaks \n (backslash n) with actual/normal linebreaks for test scripts.

@valdisvi valdisvi closed this Apr 4, 2019
@hozosch

This comment has been minimized.

Copy link
Contributor Author

hozosch commented Apr 4, 2019

Thanks valdis. I did these actual line breaks because for some reason, the automated checker didn't like them (probably caused by wrong encoding or something). The checks passed when I replaced them like that, as you should be able to see. Anyway, thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.