Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update i2c.rst #1043

Merged
merged 1 commit into from Mar 8, 2021
Merged

Update i2c.rst #1043

merged 1 commit into from Mar 8, 2021

Conversation

webeling67
Copy link
Contributor

Clarify that example config is for ESP32

Description:

I felt in the trap to assume the example config would work for ESP8266, hence the little change in the example comment

Related issue (if applicable): fixes

Pull request in esphome with YAML changes (if applicable): esphome/esphome#

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next ESPHome release. Fixes, changes and adjustments for the current release should be created against current.
  • Link added in /index.rst when creating new documents for new components or cookbook.

Clarify that example config is for ESP32
@glmnet glmnet merged commit 59fae11 into esphome:current Mar 8, 2021
@glmnet
Copy link
Member

glmnet commented Mar 8, 2021

It's ok. Actually i2c minimum config is just

i2c:

Then default pins will be selected

webeling67 added a commit to webeling67/esphome-docs that referenced this pull request Mar 11, 2021
This was referenced Mar 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants