Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update light lambda effect example #125

Merged
merged 2 commits into from Jan 17, 2019
Merged

Conversation

jdads1
Copy link
Contributor

@jdads1 jdads1 commented Jan 17, 2019

Description:

Updated example lambda as it contained erroneous brackets and did not include transition length.

Related issue (if applicable): fixes

Pull request in esphomeyaml with YAML changes (if applicable): OttoWinter/esphomeyaml#N/A
Pull request in esphomelib with C++ framework changes (if applicable): OttoWinter/esphomelib#N/A

Checklist:

  • The documentation change has been tested and compiles correctly.
  • Branch: next is for changes and new documentation that will go public with the next esphomelib release. Fixes, changes and adjustments for the current release should be created against current.

@OttoWinter
Copy link
Member

Thanks for spotting this!

Changed the PR a bit to use the "modern" way of doing this. I have plans of dropping the start_transition etc functions soon(ish). The turn_on way is what will be supported in the future.

@OttoWinter OttoWinter merged commit e30cc78 into esphome:current Jan 17, 2019
@OttoWinter OttoWinter changed the title Update index.rst Update light lambda effect example Jan 17, 2019
grea09 pushed a commit to grea09/esphomedocs that referenced this pull request Jan 28, 2019
* Update index.rst

* Use modern API
@esphome esphome locked and limited conversation to collaborators Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants