Conversation
|
Hey there @OttoWinter, mind taking a look at this pull request as its been labeled with an integration ( |
As requested esphome#1505 (comment)
test1.yml runs out of memory
OttoWinter
left a comment
There was a problem hiding this comment.
Thanks for this contribution! Sorry for the long review delay.
I just took a look at this PR, and found some minor things to address - I figured it's probably easier if I just push the changes to make it quicker.
Can you check if the component works with those changes? Thanks!
|
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
|
@OttoWinter I've tested changes locally and everything seems ok! |
Okay, it seems we can merge this then :) I've removed one change to the I2C component that, while it seems correct, probably ended up in this branch by accident. |
Otto pushed that change into this PR (a8a14c7) |
|
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
Ah, apparently I read over the part where he said he'd change the constructor visibility. Added it back in (though I do think changes like that are better done in separate PR's). |
Description:
Adds support for the LTR390 sensor, which is a UV and ambient light sensor.
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#979
Checklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: