Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LTR390 #1505

Merged
merged 26 commits into from
Sep 22, 2021
Merged

Add support for LTR390 #1505

merged 26 commits into from
Sep 22, 2021

Conversation

sjtrny
Copy link
Contributor

@sjtrny sjtrny commented Feb 1, 2021

Description:

Adds support for the LTR390 sensor, which is a UV and ambient light sensor.

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#979

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @OttoWinter, mind taking a look at this pull request as its been labeled with an integration (api) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

tests/test1.yaml Outdated Show resolved Hide resolved
@sjtrny sjtrny requested a review from jesserockz March 19, 2021 03:44
@jesserockz jesserockz added this to In Review in ESPHome Dev May 19, 2021
Copy link
Member

@OttoWinter OttoWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! Sorry for the long review delay.

I just took a look at this PR, and found some minor things to address - I figured it's probably easier if I just push the changes to make it quicker.

Can you check if the component works with those changes? Thanks!

esphome/components/ltr390/sensor.py Outdated Show resolved Hide resolved
esphome/components/ltr390/ltr390.cpp Outdated Show resolved Hide resolved
esphome/components/ltr390/ltr390.cpp Outdated Show resolved Hide resolved
esphome/components/ltr390/ltr390.cpp Show resolved Hide resolved
esphome/components/ltr390/ltr390.h Outdated Show resolved Hide resolved
@probot-esphome
Copy link

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (i2c) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@sjtrny
Copy link
Contributor Author

sjtrny commented Aug 28, 2021

@OttoWinter I've tested changes locally and everything seems ok!

@oxan
Copy link
Member

oxan commented Sep 22, 2021

@OttoWinter I've tested changes locally and everything seems ok!

Okay, it seems we can merge this then :) I've removed one change to the I2C component that, while it seems correct, probably ended up in this branch by accident.

@jesserockz
Copy link
Member

Okay, it seems we can merge this then :) I've removed one change to the I2C component that, while it seems correct, probably ended up in this branch by accident.

Otto pushed that change into this PR (a8a14c7)

@probot-esphome
Copy link

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (i2c) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@oxan
Copy link
Member

oxan commented Sep 22, 2021

Otto pushed that change into this PR (a8a14c7)

Ah, apparently I read over the part where he said he'd change the constructor visibility. Added it back in (though I do think changes like that are better done in separate PR's).

@oxan oxan merged commit b20760c into esphome:dev Sep 22, 2021
ESPHome Dev automation moved this from In Review to Done Sep 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants