Fix ESP8266 GPIO0 Pullup Validation #2572
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
ESP8266 does have a internal pullup resistors on pin GPIO0 that can
be toggled. But GPIO16 doesn't have any. I'm not sure whether there was a reason for this,
but from all reference material I could find it's like this:
Worth mentioning however is that GPIO0 usually has additional pullups anyway, because that's one of the strapping pins during boot and must be held high during that time.
Section 4.1 ESP8266EX Datasheet: https://espressif.com/sites/default/files/documentation/0a-esp8266ex_datasheet_en.pdf
TTAPA github guide: https://tttapa.github.io/ESP8266/Chap04%20-%20Microcontroller.html
Fixes esphome/issues#2574
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml
:# Example config.yaml
Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: