Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

midea: New power_toggle action. Auto-use remote transmitter. #3496

Merged
merged 4 commits into from May 23, 2022

Conversation

dudanov
Copy link
Contributor

@dudanov dudanov commented May 22, 2022

What does this implement/fix?

  1. Adds a new action midea_ac.power_toggle that is useful for reacting to a button click.
  2. Now the component automatically detects and uses remote_transmitter component. Useful when using packages. By adding a package configuring remote_transmitter the midea component will automatically start using the extended functionality via IR control.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#2094

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266

Example entry for config.yaml:

# Example config.yaml
button:
  - platform: template
    name: Midea Power Toggle
    on_press:
      midea_ac.power_toggle:

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@project-bot project-bot bot added this to Needs Review in ESPHome Dev May 22, 2022
@project-bot project-bot bot moved this from Needs Review to By Code Owner in ESPHome Dev May 22, 2022
@dudanov dudanov changed the title midea: Added power_inv action. Auto-use remote transmitter. midea: New power_toggle action. Auto-use remote transmitter. May 22, 2022
ESPHome Dev automation moved this from By Code Owner to Reviewer Approved May 22, 2022
@jesserockz jesserockz merged commit 7092f76 into esphome:dev May 23, 2022
ESPHome Dev automation moved this from Reviewer Approved to Done May 23, 2022
@dudanov dudanov deleted the midea-power-inv branch May 23, 2022 14:40
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2022
ESPHome Dev automation moved this from Done to Reviewer Approved Sep 23, 2023
ESPHome Dev automation moved this from Reviewer Approved to Done Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants