Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the same docker tags as used in HA #3752

Merged
merged 1 commit into from Sep 4, 2022
Merged

Add the same docker tags as used in HA #3752

merged 1 commit into from Sep 4, 2022

Conversation

andrey-yantsen
Copy link
Contributor

@andrey-yantsen andrey-yantsen commented Aug 29, 2022

What does this implement/fix?

This change adds YEAR.MONTH tags for the esphome's docker container.

Home Assistant provides the following docker tags for each stable release:

  • stable
  • latest
  • YEAR.MONTH

Every patch release (YEAR.MONTH.patch) has the same base set of tags. This way, a user
can set up a container using, for example, tag 2022.8 and update it automatically without the fear
of any unexpected breaking changes.

I'll update the docs if you decide to approve this PR (I'm bad with the documentation, so don't want to do it for something that won't be merged, sorry about this 😅).

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes esphome/feature-requests#1614

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#2260

Test Environment

N/A

Example entry for config.yaml:

N/A

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

docker/build.py Outdated Show resolved Hide resolved
docker/build.py Show resolved Hide resolved
@andrey-yantsen
Copy link
Contributor Author

What a shame. That's what you get when you try doing a quick patch without giving extra thought. Sorry for wasting your time yesterday.

I've fixed the issues you've noticed.

Regarding the stable: I don't mind not having it at all; I just wanted to have the same logic as in HA — they use both latest and stable. I guess the reason here is because latest could be confusing, while when you see stable, you can be sure it's a stable release.

I checked the HA installation documentation and found nothing about their YEAR.MONTH tags. Do you have any wishes on how/whether the new tag should be documented?

@jesserockz
Copy link
Member

Regarding the stable: I don't mind not having it at all; I just wanted to have the same logic as in HA — they use both latest and stable. I guess the reason here is because latest could be confusing, while when you see stable, you can be sure it's a stable release.

I guess I can see this making sense, happy for you to add it back again. Sorry for that.

I checked the HA installation documentation and found nothing about their YEAR.MONTH tags. Do you have any wishes on how/whether the new tag should be documented?

Maybe a small note somewhere on these pages would help.

Home Assistant provides the following docker tags for each stable release:

- stable
- latest
- `YEAR.MONTH`

Every patch release (`YEAR.MONTH.patch`) has the same base set of tags. This way, a user
can set up a container using, for example, tag `2022.8` and update it automatically without the fear
of any unexpected breaking changes.

This change adds `YEAR.MONTH` and `stable` tags for the esphome's docker
container.

Fixes: esphome/feature-requests#1614
@andrey-yantsen
Copy link
Contributor Author

I guess I can see this making sense, happy for you to add it back again. Sorry for that.

Let's go with stable then, no problem :)

Maybe a small note somewhere on these pages would help.

Done; esphome/esphome-docs#2260. I hope it's not too many details :)

@jesserockz jesserockz merged commit 7097b76 into esphome:dev Sep 4, 2022
@andrey-yantsen andrey-yantsen deleted the patch-1 branch September 4, 2022 08:29
@andrey-yantsen
Copy link
Contributor Author

Thanks, Jesse! :)

@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "stable" docker tag, HA style
2 participants