Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix spi timing issues" #3838

Merged
merged 1 commit into from Sep 21, 2022
Merged

Conversation

jesserockz
Copy link
Member

@jesserockz jesserockz commented Sep 21, 2022

It seems this is causing issues with existing hardware so going to revert for now until a solution can be found for everyone.

Reverts #3763

Fixes esphome/issues#3597

@jesserockz jesserockz added this to the 2022.9.1 milestone Sep 21, 2022
@project-bot project-bot bot added this to Needs Review in ESPHome Dev Sep 21, 2022
@probot-esphome
Copy link

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (spi) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

ESPHome Dev automation moved this from Needs Review to Reviewer Approved Sep 21, 2022
@landonr
Copy link
Contributor

landonr commented Sep 21, 2022

fixed the issue for me 👍

@jesserockz jesserockz merged commit 6ef9345 into dev Sep 21, 2022
ESPHome Dev automation moved this from Reviewer Approved to Done Sep 21, 2022
@jesserockz jesserockz deleted the revert-3763-SPI-bad-timing-fix branch September 21, 2022 19:38
jesserockz added a commit that referenced this pull request Sep 21, 2022
@jesserockz jesserockz mentioned this pull request Sep 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2022
ESPHome Dev automation moved this from Done to Reviewer Approved Sep 23, 2023
ESPHome Dev automation moved this from Reviewer Approved to Done Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

ttgo t-display st7789v wont display on 2022.9.0
3 participants