Fix ethernet clk_mode for GPIO0_OUT#4307
Conversation
|
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @asoehlke, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration ( |
2f99f45 to
1fb850d
Compare
|
Apologies, I mixed up my base branch and confused the bot. Things have been fixed now, but let me know if you'd rather me re-submit. |
* Fix GPIO0_OUT definition for ethernet component * Formatting --------- Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
What does this implement/fix?
The ethernet component has a bug preventing
clk_mode: GPIO0_OUTfrom working.This is due to the fact that the IDF enum for clk_mode_t has the same value for
EMAC_CLK_IN_GPIOandEMAC_APPL_CLK_OUT_GPIO(both are equal to 0), and so the logic that sets rmii.clock_mode sets the incorrect value - we would expect mode to be set to EMAC_CLK_OUT, but instead it is set to EMAC_CLK_EXT_IN.Fix is to separate the two enums and select the correct mode+gpio in the python layer.
Types of changes
Test Environment
Example entry for
config.yaml:Checklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: