Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
added download, edit and retry buttons to upload modal #557
After a failed upload, the following options are usually taken:
Related issue (if applicable): n/a
Pull request in esphome-docs with documentation (if applicable): n/a
If user exposed functionality or configuration variables are added/changed:
I'm not so sure about the placement of the overflow button - if i remember the material design guide correctly the CLOSE/END button should always be in the bottom right. But... we're not following md spec that closely anyway. If we find a better place for it, we can still move it.
For the buttons in there: I think the "edit" button is useful enough that it can be displayed next to "CLOSE" (so in the main bar). At least in the last few days I've really learned to love that EDIT button (thanks btw for that!).
While we're at it: One thing we could also do is change the SAVE&VALIDATE button in the editor to a SAVE&UPLOAD button. Reason is: the editor now performs validation on-the-fly, if you look at the left gutter you should see live validation. If you want, you can put it in this PR, though I don't want to force you to more work :)
Feel free to reposition the menu if you find a better place. For now I can't think of one...
Edit button has been moved back from menu to the main buttons.
About validation: I just saw the new live validation feature yesterday - it's awesome! Does it need to be called SAVE & UPLOAD or would UPLOAD be sufficient? What do you think about my idea of disabling it when live validation is failing?
And don't worry - that was an easy fix I was know my way around that part of the code now.
Upload is also good, yeah.
Hmm yeah that could be possible. There's one thing I would be a bit worried about though: What does it look like while typing? If the button constantly flashes disabled/enabled while typing that could be bad. But I also haven't tried so it might be ok.
I think I'll merge this PR as-is now because it looks like a neat feature and would fit well in the next beta - if you want to change other things feel free to open a new PR.
* added download, edit and retry buttons to upload modal * changed hide for disabled, resorted buttons * moved upload action buttons to menu * button changes moved edit button from menu in upload modal swapped validation button for upload in edit modal