Skip to content

Add SHT2X #5635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

Add SHT2X #5635

wants to merge 18 commits into from

Conversation

dmaasland
Copy link

@dmaasland dmaasland commented Oct 31, 2023

What does this implement/fix?

Add the SHT2x sensor component.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3347

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml
   sensor:
    - platform: sht2x
       temperature:
         name: "Living Room Temperature"
       humidity:
         name: "Living Room Humidity"

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

Copy link
Contributor

@kahrendt kahrendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a sensor to test it with, but I looked through your code and added comments for a few things that I have missed in my previous PRs. Nice work overall!

@jesserockz jesserockz marked this pull request as draft November 6, 2023 23:47
@dmaasland
Copy link
Author

Thanks for your review @kahrendt. I think i've resolved all of them :)

Copy link
Contributor

@kahrendt kahrendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Hopefully a maintainer can take a look soon as well so that it can get merged.

@dmaasland dmaasland marked this pull request as ready for review November 7, 2023 14:00
Copy link
Contributor

github-actions bot commented Feb 7, 2024

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 7, 2024
@github-actions github-actions bot closed this Feb 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants