Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend i2s config options #6056

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

Hadatko
Copy link
Contributor

@Hadatko Hadatko commented Jan 4, 2024

  • added sample_rate
  • added use_apll

What does this implement/fix?

This is minor change adding for my aplication crutial missing options sample rate and apll

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3517

Test Environment

  • [X ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • [] Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

- added sample_rate
- added use_apll

Signed-off-by: Dusan Cervenka <cervenka.dusan@gmail.com>
@probot-esphome
Copy link

probot-esphome bot commented Jan 4, 2024

Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (i2s_audio) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@jesserockz jesserockz merged commit 79d00ec into esphome:dev Jan 9, 2024
50 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
@Hadatko Hadatko deleted the feature/i2s_config_update branch January 20, 2024 12:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants