Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mcp23008 support #649

Merged
merged 11 commits into from Oct 17, 2019
Merged

Add mcp23008 support #649

merged 11 commits into from Oct 17, 2019

Conversation

@TomFahey
Copy link
Contributor

TomFahey commented Jun 19, 2019

Description:

Added support for mcp23008 io expander, based on existing support for mcp23017.

Related issue (if applicable): fixes esphome/feature-requests#41

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#277

Checklist:

  • [y] The code change is tested and works locally.
  • [y] Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

Copy link
Member

OttoWinter left a comment

Code looks good to me on a first quick look 👍

@TomFahey

This comment has been minimized.

Copy link
Contributor Author

TomFahey commented Jul 11, 2019

I'm not sure why the build is failing...? I can't see anything wrong with how the brackets are laid out?

@brandond

This comment has been minimized.

Copy link
Collaborator

brandond commented Jul 11, 2019

I'm guessing it's a whitespace change - there's either trailing whitespace after it, or you have tabs instead of spaces.

TomFahey added 3 commits Jul 11, 2019
@S-Przybylski

This comment has been minimized.

Copy link
Contributor

S-Przybylski commented Sep 25, 2019

Dear @TomFahey
dear @OttoWinter
i am interrested in using ESPHOME with MCP23008 too.
Could you be so kind to check, why the check failed? For me it seems to be a minor problem.
Thanks a lot

@TomFahey TomFahey marked this pull request as ready for review Sep 30, 2019
TomFahey added 3 commits Sep 30, 2019
Removed additional ' in line 1337
@TomFahey

This comment has been minimized.

Copy link
Contributor Author

TomFahey commented Sep 30, 2019

@S-Przybylski
@OttoWinter
Sorrry, I forgot about this! I fixed a couple typos and it passes all the tests now, so I think it should be ok to merge?

@TomFahey TomFahey closed this Oct 10, 2019
@TomFahey TomFahey reopened this Oct 10, 2019
Copy link
Member

OttoWinter left a comment

Thanks!

@OttoWinter OttoWinter merged commit 81b7653 into esphome:dev Oct 17, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@TomFahey TomFahey deleted the TomFahey:add-mcp23008-support branch Oct 24, 2019
@lock lock bot locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.