Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web_server_base AUTO_LOAD includes ASYNC_TCP #788

Merged
merged 2 commits into from Oct 21, 2019

Conversation

@Schnilz
Copy link
Contributor

Schnilz commented Oct 21, 2019

fix AUTO_LOAD of web_server_base to include ASYNC_TCP

Description:

web_server_base is missing the ASYNC_TCP in its autoload causing the config to fail with no error message.
You get
component async_tcp cannot be loaded via YAML (no CONFIG_SCHEMA).
when manualy adding web_server_base: to the yaml

Related issue (if applicable): fixes esphome/issues#760

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

Schnilz and others added 2 commits Oct 21, 2019
fix AUTO_LOAD of web_server_base to include ASYNC_TCP
Copy link
Member

OttoWinter left a comment

Thanks!

@OttoWinter OttoWinter added this to the 1.14.0 milestone Oct 21, 2019
@OttoWinter OttoWinter merged commit 9fb60b8 into esphome:dev Oct 21, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Schnilz Schnilz deleted the Schnilz:web_server_base-autoload-fix branch Oct 21, 2019
OttoWinter added a commit that referenced this pull request Oct 22, 2019
* web_server_base AUTO_LOAD includes ASYNC_TCP

fix AUTO_LOAD of web_server_base to include ASYNC_TCP

* Remove from dependencies


Co-authored-by: Otto Winter <otto@otto-winter.com>
@esphome esphome locked and limited conversation to collaborators Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.