Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upweb_server_base AUTO_LOAD includes ASYNC_TCP #788
Conversation
|
Thanks! |
OttoWinter
added a commit
that referenced
this pull request
Oct 22, 2019
* web_server_base AUTO_LOAD includes ASYNC_TCP fix AUTO_LOAD of web_server_base to include ASYNC_TCP * Remove from dependencies Co-authored-by: Otto Winter <otto@otto-winter.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Schnilz commentedOct 21, 2019
fix AUTO_LOAD of web_server_base to include ASYNC_TCP
Description:
web_server_base is missing the ASYNC_TCP in its autoload causing the config to fail with no error message.
You get
component async_tcp cannot be loaded via YAML (no CONFIG_SCHEMA).when manualy adding web_server_base: to the yaml
Related issue (if applicable): fixes esphome/issues#760
Checklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: