Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BH1750 Measurement time #997

Merged
merged 3 commits into from May 29, 2020
Merged

BH1750 Measurement time #997

merged 3 commits into from May 29, 2020

Conversation

rradar
Copy link
Contributor

@rradar rradar commented Mar 22, 2020 •
edited by glmnet

Description:

Related issue (if applicable): fixes esphome/feature-requests#148

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#515

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@rradar rradar mentioned this pull request Mar 22, 2020
Merged
2 tasks
@rradar
Copy link
Contributor Author

rradar commented Mar 23, 2020

I don't know why thing's here are failing but I use this since month's as a custom integration and it never failed once. High quality code delivered by @OttoWinter 😉

@rradar rradar mentioned this pull request Mar 25, 2020
Closed
@glmnet
Copy link
Member

glmnet commented Apr 28, 2020

can you add measurement_time to the test?

@glmnet
Copy link
Member

glmnet commented Apr 28, 2020

@rradar I re-run the travis and it's showing a lint issue now. Don't forget testx.yaml addition

@rradar
Copy link
Contributor Author

rradar commented Apr 30, 2020 •
edited

@glmnet actually I have no idea how to edit the data. I'm not even a programmer. I'm lucky that I somehow managed to make a pull request from the code @OttoWinter provided. And what the testx.yaml addition is - I have no clue!

I did - however - updated the documentation. But the pull request for it always came polluted with a lot's of other things and I have no idea where it came from (I edit the documentation with the link on the website)

@glmnet
Copy link
Member

glmnet commented Apr 30, 2020

Ahh ok, I'll take care of all this later then.

Thanks for all your support all around!

@glmnet glmnet merged commit d1f4c2a into esphome:dev May 29, 2020
@Mikaeeld Mikaeeld mentioned this pull request Jun 12, 2020
Closed
sashao pushed a commit to sashao/esphome that referenced this pull request Jun 16, 2020
@rradar @OttoWinter
@glmnet @sashao
BH1750 Measurement time (esphome#997)
fedb905 
* BH1750 Measurement time

Fixes esphome/feature-requests#148

* lint

* add test

Co-authored-by: Otto Winter <otto@otto-winter.com>
Co-authored-by: Guillermo Ruffino <glm.net@gmail.com>
natp13 pushed a commit to natp13/esphome that referenced this pull request Jun 17, 2020
@rradar @OttoWinter
@glmnet @natp13
BH1750 Measurement time (esphome#997)
1bdaa79 
* BH1750 Measurement time

Fixes esphome/feature-requests#148

* lint

* add test

Co-authored-by: Otto Winter <otto@otto-winter.com>
Co-authored-by: Guillermo Ruffino <glm.net@gmail.com>
natp13 added a commit to natp13/esphome that referenced this pull request Jun 17, 2020
@natp13
Revert "BH1750 Measurement time (esphome#997)"
103630c 
This reverts commit 1bdaa79.
@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
has-tests integration: bh1750
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support to measure more than 54612 Lux with the BH1750
3 participants
@rradar @glmnet @OttoWinter