Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use librosa's fast Griffin-Lim #1058

Merged
merged 7 commits into from Aug 8, 2019

Conversation

@kan-bayashi
Copy link
Contributor

commented Aug 8, 2019

From librosa 0.7.0, it supports fast Griffin-Lim (a.k.a. Griffin-Lim with momentum).
https://librosa.github.io/librosa/generated/librosa.core.griffinlim.html#librosa.core.griffinlim
This PR modifies the code to use librosa's Griffin-Lim.

@kan-bayashi kan-bayashi added this to the v.0.5.1 milestone Aug 8, 2019

@kan-bayashi

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

@kan-bayashi kan-bayashi requested a review from takenori-y Aug 8, 2019

@takenori-y
Copy link
Contributor

left a comment

The quality of reconstructed speech is not degraded. There is no problem at all.

else:
# use slower version of Grriffin-Lim algorithm
logging.warning("librosa version is old. use slow version of Grriffin-Lim algorithm.")
logging.warning("if you wanto use fast Griffin-Lim, "

This comment has been minimized.

Copy link
@takenori-y

takenori-y Aug 8, 2019

Contributor
Suggested change
logging.warning("if you wanto use fast Griffin-Lim, "
logging.warning("if you want to use fast Griffin-Lim, "
)
else:
# use slower version of Grriffin-Lim algorithm
logging.warning("librosa version is old. use slow version of Grriffin-Lim algorithm.")

This comment has been minimized.

Copy link
@takenori-y

takenori-y Aug 8, 2019

Contributor

The two warnings can be concatenated.

@codecov

This comment has been minimized.

Copy link

commented Aug 8, 2019

Codecov Report

Merging #1058 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1058   +/-   ##
=======================================
  Coverage   75.21%   75.21%           
=======================================
  Files          82       82           
  Lines        7698     7698           
=======================================
  Hits         5790     5790           
  Misses       1908     1908

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36bdb9a...d4c267e. Read the comment docs.

@kan-bayashi kan-bayashi merged commit 2d45419 into espnet:master Aug 8, 2019

7 checks passed

ci/circleci: test-centos7 Your tests passed on CircleCI!
Details
ci/circleci: test-debian9 Your tests passed on CircleCI!
Details
ci/circleci: test-ubuntu16 Your tests passed on CircleCI!
Details
ci/circleci: test-ubuntu18 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 36bdb9a...d4c267e
Details
codecov/project 75.21% remains the same compared to 36bdb9a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kan-bayashi kan-bayashi deleted the kan-bayashi:feature/librosa_gl branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.