Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the dependency links to github from Makefile to setup.py #858

Merged
merged 1 commit into from Jun 15, 2019

Conversation

@kamo-naoyuki
Copy link
Contributor

commented Jun 15, 2019

I moved python modules originated from github repos from Makefile to setup.py
This setup.py uses module@URL syntax pypa/pip#4175, and it was enabled on pip==19, which was released on Jan 2019.

I also added python version check.

If warp-ctc and chainer-ctc can be installed by such way, then we can freeze all python dependencies in setup.py. It may be useful for google colab environment.

@ShigekiKarita

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2019

Wonderful. In fact, this can also accelerate CI in terms of pip cache.

@ShigekiKarita ShigekiKarita added this to the v.0.4.1 milestone Jun 15, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 15, 2019

Codecov Report

Merging #858 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #858   +/-   ##
=======================================
  Coverage   50.32%   50.32%           
=======================================
  Files          88       88           
  Lines        9729     9729           
=======================================
  Hits         4896     4896           
  Misses       4833     4833

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06271ab...fb105f5. Read the comment docs.

@sw005320 sw005320 merged commit 38ea6ec into espnet:master Jun 15, 2019

7 checks passed

ci/circleci: test-centos7 Your tests passed on CircleCI!
Details
ci/circleci: test-debian9 Your tests passed on CircleCI!
Details
ci/circleci: test-ubuntu16 Your tests passed on CircleCI!
Details
ci/circleci: test-ubuntu18 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 06271ab...fb105f5
Details
codecov/project 50.32% remains the same compared to 06271ab
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.