Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use only conda to build doc #895

Merged
merged 2 commits into from Jun 20, 2019

Conversation

@ShigekiKarita
Copy link
Contributor

commented Jun 20, 2019

because some scripts under utils/*.sh, require tools/venv/bin/activate in . path.sh

@sw005320 sw005320 added this to the v.0.4.1 milestone Jun 20, 2019

@ShigekiKarita

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

@sw005320

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2019

FYI, https://espnet.github.io/espnet/ is not updated after the merge of the previous PR.
Does this PR solve it?

@ShigekiKarita

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

Previously, I accidentally turned off Build Pushed Branches in Travs CI setting. Now I turned on.

https://travis-ci.org/espnet/espnet/settings

@codecov

This comment has been minimized.

Copy link

commented Jun 20, 2019

Codecov Report

Merging #895 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #895   +/-   ##
=======================================
  Coverage   50.19%   50.19%           
=======================================
  Files          88       88           
  Lines        9780     9780           
=======================================
  Hits         4909     4909           
  Misses       4871     4871

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 790d1ba...c8f3a06. Read the comment docs.

@ShigekiKarita ShigekiKarita merged commit eef24a5 into espnet:master Jun 20, 2019

7 checks passed

ci/circleci: test-centos7 Your tests passed on CircleCI!
Details
ci/circleci: test-debian9 Your tests passed on CircleCI!
Details
ci/circleci: test-ubuntu16 Your tests passed on CircleCI!
Details
ci/circleci: test-ubuntu18 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 790d1ba...c8f3a06
Details
codecov/project 50.19% remains the same compared to 790d1ba
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ShigekiKarita ShigekiKarita referenced this pull request Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.