Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run.sh should exit if sourcing path.sh return error #954

Merged
merged 2 commits into from Jul 11, 2019

Conversation

@naxingyu
Copy link
Contributor

naxingyu commented Jul 9, 2019

Librispeech requires sentencepiece tools to be installed. Script should exist if path sourcing fails, otherwise the master script won't succeed.

@naxingyu naxingyu changed the title run.sh should exit if including path return error run.sh should exit if sourcing path.sh return error Jul 10, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #954 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #954   +/-   ##
=======================================
  Coverage   50.58%   50.58%           
=======================================
  Files          88       88           
  Lines        9880     9880           
=======================================
  Hits         4998     4998           
  Misses       4882     4882

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f0729f...9891e32. Read the comment docs.

@naxingyu

This comment has been minimized.

Copy link
Contributor Author

naxingyu commented Jul 10, 2019

@sw005320 A recent change of CI script request a module called stempeg. If USE_CONDA=true, it will request installing ffmpeg using conda. This results in CI failure. I manage to resolve it in this PR too. Now the build is passed.

@kan-bayashi

This comment has been minimized.

Copy link
Contributor

kan-bayashi commented Jul 11, 2019

Thanks a lot!

@kan-bayashi kan-bayashi added the Bugfix label Jul 11, 2019
@kan-bayashi kan-bayashi added this to the v.0.4.2 milestone Jul 11, 2019
@kan-bayashi kan-bayashi merged commit 1ac9aa3 into espnet:master Jul 11, 2019
7 checks passed
7 checks passed
ci/circleci: test-centos7 Your tests passed on CircleCI!
Details
ci/circleci: test-debian9 Your tests passed on CircleCI!
Details
ci/circleci: test-ubuntu16 Your tests passed on CircleCI!
Details
ci/circleci: test-ubuntu18 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 9f0729f...9891e32
Details
codecov/project 50.58% remains the same compared to 9f0729f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.