Skip to content

Conversation

@lucasssvaz
Copy link
Member

Description of Change

This pull request introduces support for configuring SDIO pins for external ESP MCU connections when using ESP-Hosted with NimBLE. The main changes add a new method to the BLEDevice class, allowing users to set the required pins for this setup.

ESP-Hosted NimBLE integration:

  • Added the setPins static method to the BLEDevice class in BLEDevice.h, enabling configuration of SDIO pins for communication with an external ESP MCU when ESP-Hosted with NimBLE is enabled.
  • Implemented the setPins method in BLEDevice.cpp, which calls hostedSetPins to apply the pin configuration. This method is conditionally compiled when CONFIG_ESP_HOSTED_ENABLE_BT_NIMBLE is set.

@lucasssvaz lucasssvaz requested a review from me-no-dev November 13, 2025 12:59
@lucasssvaz lucasssvaz self-assigned this Nov 13, 2025
@lucasssvaz lucasssvaz requested a review from SuGlider as a code owner November 13, 2025 12:59
@lucasssvaz lucasssvaz added the Area: BLE Issues related to BLE label Nov 13, 2025
@github-actions
Copy link
Contributor

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 6c6dbf9

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

Test Results

 76 files   76 suites   16m 53s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 6c6dbf9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C5000.000.00000.000.00
ESP32P4000.000.00000.000.00
ESP32S3000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32P4ESP32S3ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/BLE/examples/Beacon_Scanner00000000000000
libraries/BLE/examples/Client00000000000000
libraries/BLE/examples/Client_multiconnect00000000000000
libraries/BLE/examples/Client_secure_static_passkey00000000000000
libraries/BLE/examples/EddystoneTLM_Beacon00000000000000
libraries/BLE/examples/EddystoneURL_Beacon00000000000000
libraries/BLE/examples/Notify00000000000000
libraries/BLE/examples/Scan00000000000000
libraries/BLE/examples/Server00000000000000
libraries/BLE/examples/Server_multiconnect00000000000000
libraries/BLE/examples/Server_secure_authorization00--00000000--
libraries/BLE/examples/Server_secure_static_passkey00000000000000
libraries/BLE/examples/UART00000000000000
libraries/BLE/examples/Write00000000000000
libraries/BLE/examples/iBeacon00000000000000

@lucasssvaz lucasssvaz added the Status: Pending Merge Pull Request is ready to be merged label Nov 13, 2025
@me-no-dev me-no-dev merged commit 3cad849 into espressif:master Nov 14, 2025
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: BLE Issues related to BLE Status: Pending Merge Pull Request is ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants