Skip to content

Conversation

@eMUQI
Copy link
Contributor

@eMUQI eMUQI commented Nov 14, 2025

Description of Change

This PR enables CDC on Boot by default for the Waveshare ESP32-S3-ZERO board.

This board does not include a dedicated USB-to-UART converter and relies on its native USB for serial communication. The previous default (Disabled) prevented the serial monitor from working out-of-the-box, leading to a confusing user experience. This change ensures that Serial.print() functions as expected immediately after flashing, significantly improving usability.

https://www.waveshare.com/wiki/ESP32-S3-Zero
https://files.waveshare.com/wiki/ESP32-S3-Zero/ESP32-S3-Zero-Sch.pdf

Test Scenarios

N/A

Related links

N/A

@eMUQI eMUQI requested a review from P-R-O-C-H-Y as a code owner November 14, 2025 09:52
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello eMUQI, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 522e151

@SuGlider SuGlider self-requested a review November 14, 2025 14:58
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. labels Nov 14, 2025
@me-no-dev me-no-dev merged commit da663f3 into espressif:master Nov 14, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants