Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix F_Fat::format return false when succeed #3220

Merged
merged 1 commit into from Sep 20, 2019

Conversation

@luc-github
Copy link
Contributor

commented Sep 17, 2019

this is due to usage of esp_err_t result; instead of boolean, ESP_OK = 0, so it is false

this is due to ussage of esp_err_t result; instead of boolean, ESP_OK =0 so it is false
@me-no-dev

This comment has been minimized.

Copy link
Member

commented Sep 17, 2019

@lbernstone want to have a look?

@lbernstone

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

Looks good to me.

@luc-github

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2019

@lbernstone thank you ^_^

@me-no-dev me-no-dev merged commit 56fe2db into espressif:master Sep 20, 2019
20 checks passed
20 checks passed
Build Arduino IDE Tests 0
Details
Build Arduino IDE Tests 1
Details
Build Arduino IDE Tests 2
Details
Build Arduino IDE Tests 3
Details
Build Arduino IDE Tests 4
Details
Build Arduino IDE Tests 5
Details
Build Arduino IDE Tests 6
Details
Build Arduino IDE Tests 7
Details
Build Arduino IDE Tests 8
Details
Build Arduino IDE Tests 9
Details
Build Arduino IDE Tests 10
Details
Build Arduino IDE Tests 11
Details
Build Arduino IDE Tests 12
Details
Build Arduino IDE Tests 13
Details
Build Arduino IDE Tests 14
Details
Build Arduino IDE Tests 15
Details
Build Arduino IDE Tests 16
Details
Build Arduino IDE Tests 17
Details
Build PlatformIO Tests
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.