Makes BluetoothSerial optional for NimBLE compatibility #5970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pataclop seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
me-no-dev
reviewed
Dec 14, 2021
| set(requires spi_flash mbedtls mdns esp_adc_cal wifi_provisioning nghttp) | ||
| set(priv_requires fatfs nvs_flash app_update spiffs bootloader_support openssl bt esp_ipc esp_hid) | ||
|
|
||
| if(NOT CONFIG_ARDUINO_SELECTIVE_COMPILATION OR CONFIG_ARDUINO_SELECTIVE_BluetoothSerial) |
Member
There was a problem hiding this comment.
this should be done in the source files and not here
Author
There was a problem hiding this comment.
Okay ! Wasn't sure which approach was the best, I'll change it :)
Member
|
Closing this PR as the issue no longer exists. Tested with Arduino core master as an idf component without any related compilation errors/ warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, BluetoothSerial makes it impossible to run both arduino-esp32 and NimBLE.
How to reproduce the original problem
esp-idf version: release/v4.4
arduino-esp32 version: 2.0.1
Steps:
idf.py menuconfigComponent Configuration / Bluetooth / Bluetooth Hostand set it toNimBLE.Impact
This Pull-Request makes it possible to use arduino-esp32 with NimBLE, by making the compilation BluetoothSerial optional. To fix the issue, you thus need to:
idf.py menuconfigArduino ConfigurationInclude only specific Arduino librariesEnable BluetoothSerialWe could probably, additionally, make that option depend on the BLE host, but I'm not sure how to do so, nor whether it's a good idea to.