Skip to content

Conversation

@david-cermak
Copy link
Contributor

@david-cermak david-cermak commented Aug 26, 2025

Copy link

@mantriyogesh mantriyogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fantastic.

  1. Some refinements might be needed.
  2. Top image could be simpler and intuitive.

@david-cermak
Copy link
Contributor Author

Overall looks fantastic.

  1. Some refinements might be needed.
  2. Top image could be simpler and intuitive.

Thanks for the valuable comments, I'll think about that featured picture (and still need to make some edits, mainly to pictures)

Also, wanted to use some common terminology for the "RPC library", any idea? I sometimes use "RPC implementation component", "RPC library" or "RPC implementor lib"...

@david-cermak
Copy link
Contributor Author

@glmfe @euripedesrocha PTAL

Copy link
Contributor

@euripedesrocha euripedesrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments.
Nice article!

@david-cermak
Copy link
Contributor Author

Just a few comments. Nice article!

Thanks for the review and comments!

@mantriyogesh
Copy link

In Choosing the backend solution , should we include low level how to choose it from idf.py menuconfig ?

@david-cermak
Copy link
Contributor Author

In Choosing the backend solution , should we include low level how to choose it from idf.py menuconfig ?

Very good point, thanks! Have added (+ added the custom option, which is also available)

@pedrominatel pedrominatel added the needs review Needs someone to be assigned to review label Sep 2, 2025
@david-cermak
Copy link
Contributor Author

Thanks for the review @euripedesrocha @mantriyogesh !

@f-hollow PTAL

Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @david-cermak, please find my comments. Thank you for your collaboration!

@david-cermak
Copy link
Contributor Author

please find my comments. Thank you for your collaboration!

Thanks for taking a look! Fixed as suggested, just kept one discussion open -> please resolve if it sound good to you.

Copy link
Collaborator

@f-hollow f-hollow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-cermak Thank you for writing the article!

I have a few comments that generally try to uphold the following principles:

  • Refer to things in the same way or use unified terminology in the article. One example is WiFi-less vs. WiFi-enabled vs. WiFi-capable, or local WiFi vs. native WiFi, etc.
  • Create a narrative so that the text evolves from one topic or idea to another. This helps avoid repeating the same facts in different combinations.

I reviewed the article up until the heading WiFi Remote component breakdown.

I will continue my review tomorrow.

Copy link
Collaborator

@f-hollow f-hollow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nitpicks. Otherwise, LGTM!

@david-cermak
Copy link
Contributor Author

@f-hollow @pedrominatel Thank you for the review and your valuable suggestions!

@pedrominatel pedrominatel merged commit 748279e into espressif:main Sep 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review Needs someone to be assigned to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants