From 5276b266784ad28c9e6108572a388439fdc7e7ca Mon Sep 17 00:00:00 2001 From: Marcio Bulla Date: Fri, 18 Jul 2025 01:08:22 -0300 Subject: [PATCH] fix: add #include and parentheses --- components/knob/include/iot_knob.h | 1 + components/knob/iot_knob.c | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/components/knob/include/iot_knob.h b/components/knob/include/iot_knob.h index 68f778d3f0..b95148e5fa 100644 --- a/components/knob/include/iot_knob.h +++ b/components/knob/include/iot_knob.h @@ -7,6 +7,7 @@ #pragma once #include +#include #include "esp_err.h" #ifdef __cplusplus diff --git a/components/knob/iot_knob.c b/components/knob/iot_knob.c index 11a56dbfd8..6bd16253e0 100644 --- a/components/knob/iot_knob.c +++ b/components/knob/iot_knob.c @@ -218,8 +218,8 @@ static void knob_cb(void *args) if (target->enable_power_save) { knob_gpio_wake_up_control((uint32_t)target->encoder_a, !target->encoder_a_level, true); knob_gpio_wake_up_control((uint32_t)target->encoder_b, !target->encoder_b_level, true); - knob_gpio_set_intr((uint32_t)target->encoder_a, !target->encoder_a_level == 0 ? GPIO_INTR_LOW_LEVEL : GPIO_INTR_HIGH_LEVEL); - knob_gpio_set_intr((uint32_t)target->encoder_b, !target->encoder_b_level == 0 ? GPIO_INTR_LOW_LEVEL : GPIO_INTR_HIGH_LEVEL); + knob_gpio_set_intr((uint32_t)target->encoder_a, !(target->encoder_a_level == 0) ? GPIO_INTR_LOW_LEVEL : GPIO_INTR_HIGH_LEVEL); + knob_gpio_set_intr((uint32_t)target->encoder_b, !(target->encoder_b_level == 0) ? GPIO_INTR_LOW_LEVEL : GPIO_INTR_HIGH_LEVEL); knob_gpio_intr_control((uint32_t)(target->encoder_a), true); knob_gpio_intr_control((uint32_t)(target->encoder_b), true); } @@ -262,8 +262,8 @@ knob_handle_t iot_knob_create(const knob_config_t *config) if (config->enable_power_save) { knob->enable_power_save = config->enable_power_save; - knob_gpio_init_intr(config->gpio_encoder_a, !knob->encoder_a_level == 0 ? GPIO_INTR_LOW_LEVEL : GPIO_INTR_HIGH_LEVEL, knob_power_save_isr_handler, knob->encoder_a); - knob_gpio_init_intr(config->gpio_encoder_b, !knob->encoder_b_level == 0 ? GPIO_INTR_LOW_LEVEL : GPIO_INTR_HIGH_LEVEL, knob_power_save_isr_handler, knob->encoder_b); + knob_gpio_init_intr(config->gpio_encoder_a, !(knob->encoder_a_level == 0) ? GPIO_INTR_LOW_LEVEL : GPIO_INTR_HIGH_LEVEL, knob_power_save_isr_handler, knob->encoder_a); + knob_gpio_init_intr(config->gpio_encoder_b, !(knob->encoder_b_level == 0) ? GPIO_INTR_LOW_LEVEL : GPIO_INTR_HIGH_LEVEL, knob_power_save_isr_handler, knob->encoder_b); ret = knob_gpio_wake_up_init(config->gpio_encoder_a, !knob->encoder_a_level); KNOB_CHECK_GOTO(ESP_OK == ret, "encoder A wake up gpio init failed", _encoder_deinit);