Skip to content
Permalink
Browse files

3152: Remove nocheck-maxset job in CI

Fixes #3095

Removed:
- the last remaining debug macros
- the nocheck-maxset job and its config file
- unused or unimplemented debug functions
- obsolete includes: debug.hpp, cstdio (for fprintf), cstring (for memcopy), etc.
- documentation of non-existent features (relics of old cleanup PRs)
  • Loading branch information...
jngrad committed Sep 11, 2019
2 parents 7161bad + 60931c1 commit 5c6984214c032a94f85bb7a3469e7271fd888c5b
@@ -123,16 +123,6 @@ no_rotation:
- docker
- linux

nocheckmaxset:
<<: *global_job_definition
stage: build
script:
- export with_cuda=false myconfig=nocheck-maxset make_check=false
- bash maintainer/CI/build_cmake.sh
tags:
- docker
- linux

### Builds with different Distributions

#debian:8 removed: similar to ubuntu:1404
@@ -405,8 +405,6 @@ General features
- ``COMFIXED`` Allows to fix the center of mass of all particles of a certain type.
- ``MOLFORCES`` (EXPERIMENTAL)
- ``BOND_CONSTRAINT`` Turns on the RATTLE integrator which allows for fixed lengths bonds
between particles.
@@ -537,29 +535,12 @@ Some of the short-range interactions have additional features:
Debug messages
^^^^^^^^^^^^^^
Finally, there are a number of flags for debugging. The most important
one are
Finally, there is a flag for debugging:
- ``ADDITIONAL_CHECKS`` Enables numerous additional checks which can detect inconsistencies
especially in the cell systems. These checks are however too slow to
be enabled in production runs.
The following flags control the debug output of various sections of
|es|. You will however understand the output very often only by
looking directly at the code.
- ``VIRTUAL_SITES_DEBUG``
- ``ASYNC_BARRIER`` Introduce a barrier after each asynchronous command completion. Helps
in the detection of mismatching communication.
- ``FORCE_CORE`` Causes |es| to try to provoke a core dump when exiting unexpectedly.
- ``MPI_CORE`` Causes |es| to try this even with MPI errors.
- ``CUDA_DEBUG``
Features marked as experimental
@@ -510,11 +510,6 @@ Please note that the velocity attribute of the virtual particles does not carry
The behavior of virtual sites can be fine-tuned with the following
switches in :file:`myconfig.hpp`.
- ``VIRTUAL_SITES_NO_VELOCITY`` specifies that the velocity of virtual sites is not computed
- ``VIRTUAL_SITES_THERMOSTAT`` specifies that the Langevin thermostat should also act on virtual
sites
- ``THERMOSTAT_IGNORE_NON_VIRTUAL`` specifies that the thermostat does not act on non-virtual particles
.. _Particle number counting feature:

This file was deleted.

@@ -110,10 +110,6 @@ NO_INTRA_NB notest
/* Debugging */
ADDITIONAL_CHECKS

VIRTUAL_SITES_DEBUG
CUDA_DEBUG


# External switches
# Switches that are set by configure or gcc, not to be set manually
CUDA external
@@ -19,8 +19,6 @@
#ifndef ESPRESSOSYSTEMINTERFACE_H
#define ESPRESSOSYSTEMINTERFACE_H

#include <cstdio>

#include "SystemInterface.hpp"
#include "cuda_interface.hpp"
#include "debug.hpp"
@@ -511,7 +511,6 @@ int Correlator::finalize() {
// Lets find out how far we have to go back in the hierarchy to make space
// for the new value
while (highest_level_to_compress > -1) {
// printf("test level %d for compression, n_vals=%d ... ",i,n_vals[i]);
if (n_vals[i] % 2) {
if (i < (hierarchy_depth - 1) && n_vals[i] > m_tau_lin) {
highest_level_to_compress += 1;
@@ -120,7 +120,6 @@
#include <boost/serialization/access.hpp>

#include <cmath>
#include <cstdio>
#include <cstdlib>
#include <map>
#include <memory>
@@ -26,7 +26,6 @@
#ifdef DIPOLAR_BARNES_HUT

#include <cstdio>
#include <ctime>
#include <iostream>

typedef float dds_float;
@@ -89,12 +89,6 @@ void _cuda_safe_mem(cudaError_t CU_err, const char *file, unsigned int line) {
void _cuda_check_errors(const dim3 &block, const dim3 &grid,
const char *function, const char *file,
unsigned int line) {
/** If debugging is enabled, wait for Kernels to terminate before checking for
* errors. This removes parallelism between host and device and should only be
* enabled while debugging. */
#ifdef CUDA_DEBUG
cudaDeviceSynchronize();
#endif
CU_err = cudaGetLastError();
if (CU_err != cudaSuccess) {
fprintf(stderr,
@@ -23,7 +23,6 @@

#include "communication.hpp"
#include "config.hpp"
#include "debug.hpp"
#include "energy.hpp"
#include "nonbonded_interactions/nonbonded_interaction_data.hpp"
#include "serialization/CUDA_particle_data.hpp"
@@ -24,20 +24,11 @@

#include "debug.hpp"

#include <csignal>
#include <cstdio>
#include <cstdlib>
#include <cstring>
#include <mpi.h>
#include <unistd.h>

#include "cells.hpp"
#include "communication.hpp"
#include "errorhandling.hpp"
#include "grid.hpp"
#include "integrate.hpp"

int regular_exit = 1;

void check_particle_consistency() {
int n, c;
@@ -143,78 +134,6 @@ void check_particle_consistency() {
}
}

void check_particles() {
int n, c;
int cell_part_cnt = 0, local_part_cnt = 0;
int cell_err_cnt = 0;
double const skin2 = (skin != -1) ? skin / 2 : 0;

/* checks: part_id, part_pos, local_particles id */
for (c = 0; c < local_cells.n; c++) {
auto const cell = local_cells.cell[c];
cell_part_cnt += cell->n;
for (int n = 0; n < cell->n; n++) {
auto const &p = cell->part[n];
if (p.p.identity < 0 || p.p.identity > max_seen_particle) {
fprintf(
stderr,
"%d: check_particles: ERROR: Cell %d Part %d has corrupted id=%d\n",
this_node, c, n, p.p.identity);
errexit();
}

for (int dir = 0; dir < 3; dir++) {
if (box_geo.periodic(dir) &&
(p.r.p[dir] < -skin2 ||
p.r.p[dir] > box_geo.length()[dir] + skin2)) {
fprintf(stderr,
"%d: check_particles: ERROR: illegal pos[%d]=%f of "
"part %d id=%d in cell %d\n",
this_node, dir, p.r.p[dir], n, p.p.identity, c);
errexit();
}
}
if (local_particles[p.p.identity] != &p) {
fprintf(stderr,
"%d: check_particles: ERROR: address mismatch for part "
"id %d: local: %p cell: %p in cell %d\n",
this_node, p.p.identity,
static_cast<void *>(local_particles[p.p.identity]),
static_cast<void const *>(&p), c);
errexit();
}
}
}

/* checks: local particle id */
for (n = 0; n <= max_seen_particle; n++) {
if (local_particles[n] != nullptr) {
local_part_cnt++;
if (local_particles[n]->p.identity != n) {
fprintf(stderr,
"%d: check_particles: ERROR: local_particles part %d "
"has corrupted id %d\n",
this_node, n, local_particles[n]->p.identity);
errexit();
}
}
}

/* EXIT on severe errors */
if (cell_err_cnt > 0) {
fprintf(stderr,
"%d: check_particles: %d ERRORS detected in cell structure!\n",
this_node, cell_err_cnt);
errexit();
}
}

/**
* @brief Check if particles are in correct cells.
*
* Check that particles are in the cells the cellsystem says
* they should be.
*/
void check_particle_sorting() {
for (int c = 0; c < local_cells.n; c++) {
auto const cell = local_cells.cell[c];
@@ -22,10 +22,6 @@
* This file controls debug facilities.
*
* Implementation in debug.cpp.
*
* For every define there exists a macro that can be used to encapsulate
* short lines (like printf("...",...);) of code that should be executed
* iff the respective *_DEBUG macro is defined.
*/

#include "config.hpp"
@@ -35,20 +31,12 @@
*/
void check_particle_consistency();

/** check the consistency of the cells and particle_node.
/**
* @brief Check if particles are in correct cells.
*
* Check that particles are in the cells the cellsystem says
* they should be.
*/
void check_particles();

void check_particle_sorting();

/** Print all particle positions contained in \ref cells::cells array. */
void print_particle_positions();
/** Print all particle forces contained in \ref cells::cells array. */
void print_particle_forces();

extern int this_node;

/** by setting this variable to 1, a regular exit is
* indicated. In that case, no core dump is generated.
*/
extern int regular_exit;
@@ -29,9 +29,6 @@

#include <cmath>
#include <cstddef>
#include <cstdio>
#include <cstdlib>
#include <cstring>

#include "PartCfg.hpp"
#include "bonded_interactions/bonded_interaction_data.hpp"
@@ -30,9 +30,7 @@

#include <cmath>
#include <cstddef>
#include <cstdio>
#include <cstdlib>
#include <cstring>

#include "electrostatics_magnetostatics/p3m_gpu.hpp"

@@ -33,11 +33,6 @@
#include <mpi.h>
#include <utils/mpi/cart_comm.hpp>

#include <cmath>
#include <cstdio>
#include <cstdlib>
#include <cstring>

/**********************************************
* variables
**********************************************/
@@ -26,7 +26,6 @@

#include <boost/range/numeric.hpp>

#include "debug.hpp"
#include "grid.hpp"
#include "grid_based_algorithms/lattice.hpp"
#include <utils/constants.hpp>
@@ -32,7 +32,6 @@
#include "cells.hpp"
#include "communication.hpp"
#include "cuda_interface.hpp"
#include "debug.hpp"
#include "global.hpp"
#include "grid.hpp"
#include "grid_based_algorithms/lb_boundaries.hpp"
@@ -58,7 +57,6 @@ using Utils::get_linear_index;

#include <cassert>
#include <cinttypes>
#include <cstdio>
#include <fstream>
#include <iostream>

0 comments on commit 5c69842

Please sign in to comment.
You can’t perform that action at this time.