Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of Wire library. #226

Open
Koepel opened this Issue Jan 17, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@Koepel
Copy link

Koepel commented Jan 17, 2019

In the file "esp-rfid/src/PN532.cpp" is a Utils::DelayMilli(1); (at the moment in line 950) when reading data with I2cClass::Read();. That delay may be removed.

The origin is at Adafruit, so I have made this issue.

@omersiar

This comment has been minimized.

Copy link
Collaborator

omersiar commented Jan 18, 2019

Thank you for reporting.

While it is based on Adafruit's initial code, Elmue did great job improving and polishing it. Please check it out.

http://netcult.ch/elmue/
https://www.codeproject.com/Articles/1096861/DIY-electronic-RFID-Door-Lock-with-Battery-Backup
https://www.codeproject.com/Members/Elmue

@Koepel

This comment has been minimized.

Copy link
Author

Koepel commented Jan 18, 2019

Thanks. I have written a message on his project page at codeproject. Maybe he will fix in a future version.
It is not a bug. It is only a small delay that is not needed.

@omersiar omersiar added the suggestion label Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.